Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Remove reference to clippy::manual-strip. #9794

Conversation

waywardmonkeys
Copy link
Contributor

This should have been removed in 8a9f475 when the rest of the references to / usages of clippy::manual-strip were removed. It was originally needed in the long ago past when supporting Rust 1.45 was a concern.

Objective

  • Docs on linting should match the actual current practice.
  • Docs currently mention -A clippy::manual-strip which hasn't been needed in a long time.

Solution

  • Remove reference to -A clippy::manual-strip.

This should have been removed in 8a9f475
when the rest of the references to / usages of `clippy::manual-strip`
were removed. It was originally needed in the long ago past when
supporting Rust 1.45 was a concern.
@nicopap nicopap added C-Docs An addition or correction to our documentation A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Sep 13, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 14, 2023
Merged via the queue into bevyengine:main with commit 8192ac6 Sep 14, 2023
25 checks passed
@waywardmonkeys waywardmonkeys deleted the remove-reference-to-manual-strip-lint branch September 14, 2023 13:04
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
This should have been removed in
8a9f475 when the rest of the references
to / usages of `clippy::manual-strip` were removed. It was originally
needed in the long ago past when supporting Rust 1.45 was a concern.

# Objective

- Docs on linting should match the actual current practice.
- Docs currently mention `-A clippy::manual-strip` which hasn't been
needed in a long time.

## Solution

- Remove reference to `-A clippy::manual-strip`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants