Return a boolean from set_if_neq
#9801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJet
added
A-ECS
alice-i-cecile
approved these changes
Sep 14, 2023
|
Good call, I should have done this originally. |
hymm
approved these changes
Sep 14, 2023
hymm
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Sep 14, 2023
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective When using `set_if_neq`, sometimes you'd like to know if the new value was different from the old value so that you can perform some additional branching. ## Solution Return a bool from this function, which indicates whether or not the value was overwritten. --- ## Changelog * `DetectChangesMut::set_if_neq` now returns a boolean indicating whether or not the value was changed. ## Migration Guide The trait method `DetectChangesMut::set_if_neq` now returns a boolean value indicating whether or not the value was changed. If you were implementing this function manually, you must now return `true` if the value was overwritten and `false` if the value was not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
When using
set_if_neq, sometimes you'd like to know if the new value was different from the old value so that you can perform some additional branching.Solution
Return a bool from this function, which indicates whether or not the value was overwritten.
Changelog
DetectChangesMut::set_if_neqnow returns a boolean indicating whether or not the value was changed.Migration Guide
The trait method
DetectChangesMut::set_if_neqnow returns a boolean value indicating whether or not the value was changed. If you were implementing this function manually, you must now returntrueif the value was overwritten andfalseif the value was not.