Small tidy up. Fixed existing bug whereby we'd set bot options by nam…

…e rather than playerId (resulting in the abiltiy to not uniquely set options for susequent bots).

src/renderer/components/battle/BotParticipant.vue

@@ -20,7 +20,7 @@
 import { Icon } from "@iconify/vue";
 import robot from "@iconify-icons/mdi/robot";
 import { MenuItem } from "primevue/menuitem";
-import { Ref, ref } from "vue";
+import { Ref, ref, toRaw } from "vue";
 
 import LuaOptionsModal from "@/components/battle/LuaOptionsModal.vue";
 import TeamParticipant from "@/components/battle/TeamParticipant.vue";
@@ -80,8 +80,7 @@ async function configureBot() {
 }
 
 function setBotOptions(options: Record<string, unknown>) {
-    console.log("Set bot options");
-    props.battle.setBotOptions(props.bot.name, options);
+    props.battle.setBotOptions(props.bot.playerId, options);
 }
 </script>
 

src/renderer/model/battle/abstract-battle.ts

@@ -90,6 +90,19 @@ export abstract class AbstractBattle<T extends BattleOptions = BattleOptions> {
         });
     }
 
+    // Returns a bot by it's PlayerId. Returns undefined if not found..
+    public getBotParticipantByPlayerId(playerId: number): User | Bot | undefined {
+        return this.participants.value.find((participant) => {
+            const isBot = !("userId" in participant);
+            if (isBot) {
+                if (participant.playerId === playerId) {
+                    return true;
+                }
+            }
+            return false;
+        });
+    }
+
     public open() {
         this.watchStopHandles = [
             watch(
@@ -137,7 +150,7 @@ export abstract class AbstractBattle<T extends BattleOptions = BattleOptions> {
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     public abstract setGameOptions(options: Record<string, any>): void;
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    public abstract setBotOptions(botName: string, options: Record<string, any>): void;
+    public abstract setBotOptions(playerId: number, options: Record<string, any>): void;
     public abstract addBot(bot: Bot): void;
     public abstract removeBot(bot: Bot): void;
     public abstract playerToSpectator(player: User): void;

src/renderer/model/battle/offline-battle.ts

@@ -72,8 +72,8 @@ export class OfflineBattle extends AbstractBattle {
         this.fixIds();
     }
 
-    public setBotOptions(botName: string, options: Record<string, unknown>) {
-        const bot = this.getParticipantByName(botName) as Bot;
+    public setBotOptions(playerId: number, options: Record<string, unknown>) {
+        const bot = this.getBotParticipantByPlayerId(playerId) as Bot;
         bot.aiOptions = options;
     }
 

src/renderer/model/battle/spads-battle.ts

@@ -364,7 +364,7 @@ export class SpadsBattle extends AbstractBattle<SpadsBattleOptions> {
     }
 
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    public setBotOptions(botName: string, options: Record<string, any>) {
+    public setBotOptions(playerId: number, options: Record<string, any>) {
         console.warn("not implemented: setBotOptions");
         // TODO
     }