Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracy.LuaTracyPlot and tracy.LuaTracyPlotConfig #1651

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

sprunk
Copy link
Collaborator

@sprunk sprunk commented Aug 18, 2024

#1215 but in the tracy. namespace, 100% free when not using tracy builds, and no code from rts/lib/tracy/* was touched so there won't be any issues with updating the lib in the future.

rts/Lua/LuaTracyExtra.h Outdated Show resolved Hide resolved
rts/Lua/LuaTracyExtra.cpp Outdated Show resolved Hide resolved
@sprunk sprunk requested a review from p2004a August 23, 2024 02:31
@lhog
Copy link
Collaborator

lhog commented Oct 6, 2024

So we close #1215 and merge this one?

@sprunk
Copy link
Collaborator Author

sprunk commented Oct 6, 2024

Yes, but also @Beherith has never said anything about 1651 while he was the one to request the feature and is the author of 1215.

@Beherith
Copy link
Contributor

its stunning, thank you!

@saurtron
Copy link
Collaborator

rebased

@saurtron saurtron added the candidate PRs that should be good to go or important for next release label Dec 16, 2024
@Beherith Beherith merged commit 6760620 into master Dec 23, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 24, 2024
Co-authored-by: Beherith <mysterme@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate PRs that should be good to go or important for next release Lua API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants