Make Cannon respect srcPos on HaveFreeLineOfFire. #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done
Details
I think all other weapons do this.
Looks safe since the only in-engine user is
HaveFreeLineOfFire(GetAimFromPos(preFire), tgtPos, trg)at TryTarget. AndGetAimFromPosfor cannon is hardcoded to use weaponMuzzlePos anyways. (see Cannon.h).Could break lua api users (GetUnitWeaponHaveFreeLineOfFire) but I think those seem fine too (actually the fix is for them) since also using GetAimFromPos unless user wants a different srcPos.
Marking as "lua api" since afaics this only affects
Spring.GetUnitWeaponHaveFreeLineOfFire.