Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace recursion flag from boolean to int #95

Merged

Conversation

badosu
Copy link
Collaborator

@badosu badosu commented Oct 16, 2021

Max depth controlled by MAX_CMD_RECURSION_DEPTH

badosu added a commit to beyond-all-reason/Beyond-All-Reason that referenced this pull request Oct 16, 2021
A small recursion happens that triggers an error.

Enable back when beyond-all-reason/spring#95
gets merged
rts/Lua/LuaSyncedCtrl.cpp Outdated Show resolved Hide resolved
rts/Lua/LuaSyncedCtrl.h Outdated Show resolved Hide resolved
rts/Lua/LuaSyncedCtrl.h Outdated Show resolved Hide resolved
rts/Lua/LuaSyncedCtrl.cpp Outdated Show resolved Hide resolved
rts/Lua/LuaSyncedCtrl.cpp Outdated Show resolved Hide resolved
@badosu badosu force-pushed the badosu/add-max-cmd-depth-recursion-flag branch 2 times, most recently from 511888f to f125523 Compare October 16, 2021 15:03
Max depth controlled by MAX_CMD_RECURSION_DEPTH
@badosu badosu force-pushed the badosu/add-max-cmd-depth-recursion-flag branch from f125523 to de1a819 Compare October 16, 2021 15:46
@badosu
Copy link
Collaborator Author

badosu commented Oct 16, 2021

@lhog Let me know if there are any pending issues

rts/Lua/LuaSyncedCtrl.cpp Outdated Show resolved Hide resolved
rts/Lua/LuaSyncedCtrl.h Outdated Show resolved Hide resolved
rts/Lua/LuaSyncedCtrl.h Outdated Show resolved Hide resolved
@lhog lhog merged commit 1b61dbe into beyond-all-reason:BAR105 Oct 16, 2021
@badosu badosu deleted the badosu/add-max-cmd-depth-recursion-flag branch October 16, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants