Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support args in cp #109

Merged
merged 3 commits into from
Nov 16, 2021
Merged

feat: Support args in cp #109

merged 3 commits into from
Nov 16, 2021

Conversation

JinnyYi
Copy link
Contributor

@JinnyYi JinnyYi commented Nov 15, 2021

ref: #107

@Xuanwo Xuanwo mentioned this pull request Nov 15, 2021
Closed
Xuanwo
Xuanwo reviewed Nov 15, 2021
View reviewed changes
cmd/byctl/cp.go Outdated
zap.String("dst", dstKey),
zap.Error(err))
return err
var chList []chan *operations.EmptyResult
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the same question: Let's do them one by one, and don't need to take care of the concurrency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@Xuanwo Xuanwo merged commit a1ebea8 into beyondstorage:master Nov 16, 2021
@JinnyYi JinnyYi deleted the args-cp branch November 16, 2021 05:40
@BeyondRobot BeyondRobot mentioned this pull request Nov 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JinnyYi @Xuanwo