This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
feat: Implement CreateLink and setup linker test in go-service-fs #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Aug 2, 2021
Xuanwo
reviewed
Aug 2, 2021
storage.go
Outdated
|
|
||
| target, err := filepath.EvalSymlinks(rp) | ||
|
|
||
| // FIXME |
There was a problem hiding this comment.
Please give more information for FIXME.
- What's the problem?
- What we did for this problem?
There was a problem hiding this comment.
Is it related to #64?
Yes, it is.
There was a problem hiding this comment.
Is it related to #64?
Yes, it is.
This is not good.
Please don't assume that others know the context, and do your best to put all the information you know in a comment or at least in a PR.
Imagine if you were an external contributor and saw a line like this FIXME, how would you feel? Even if you wanted to contribute, you wouldn't be able to participate.
The most important thing for BeyondStorage: Be open.
There was a problem hiding this comment.
Got it, I will take care of that in the future.
Xuanwo
approved these changes
Aug 2, 2021
3 tasks
24 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Implement CreateLink and setup linker test in go-service-fs