Basic Implement of OneDrive Storager #17
Conversation
… in SDK, but we prefer to use path
change it into utils_token.go
|
|
|
Great work! Give me some time to review the details.. |
|
I think we can create an error code like below and returns it when size=0, but this doesn't pass integration test. var ErrWriteFileEmpty = services.NewErrorCode("onedrive doesn't support upload empty file")I think GSP-751 just considered the API flavor, but doesn't consider the case where writing empty file is not supported... Ping @abyss-w and @JinnyYi |
|
The build CI fails, and you can see it's format check: https://github.com/beyondstorage/go-service-onedrive/runs/3722658754 You can run |
We need to specify the expected behavior when writing an empty file is not supported. For integration test, how about splitting integration test cases like what we did for |
|
I think we need to come up with a solution like feature flags or something. Can you just pin the go-integration-test to the older version and leave a comment on this comment? We expect to solve this problem in October. |
|
okok ,I will fix it soon.😃
…---Original---
From: ***@***.***>
Date: Tue, Sep 28, 2021 21:43 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [beyondstorage/go-service-onedrive] Basic Implement of OneDrive Storager (#17)
@xxchan commented on this pull request.
In go.sum:
> github.com/Xuanwo/templateutils v0.1.0 h1:WpkWOqQtIQ2vAIpJLa727DdN8WtxhUkkbDGa6UhntJY= github.com/Xuanwo/templateutils v0.1.0/go.mod h1:OdE0DJ+CJxDBq6psX5DPV+gOZi8bhuHuVUpPCG++Wb8= +<<<<<<< HEAD
please run make build again to clean it
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
… the older version
|
okok.
…---Original---
From: ***@***.***>
Date: Tue, Sep 28, 2021 11:27 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [beyondstorage/go-service-onedrive] Basic Implement of OneDrive Storager (#17)
I think we need to come up with a solution like feature flags or something. Can you just pin the go-integration-test to the older version and leave a comment on this comment?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
|
Nice work! Next, let's add docs like:
At the same time, don't forget the deadline of the final report of OSPP! |
Sorry for the late pull request.
The past few days I study the onedrive documents and beyondstorage specs, so it takes time to finish a basic one drive client and some adjust for the latest behavior.
For now, I have implement the basic storager for one drive, but the newest GSP-751 and one-drive conflict with the design of the empty file, the latter doesn't allow empty file exist, I didn’t found ways to avoid that, so I think this could to be discuss later.
ref: https://stackoverflow.com/questions/64772346/uploading-empty-0-byte-to-sharepoint-online (since the ms voice has shut down …)
TL;DR:
This storage has pass the integration-test except the part of zero size file.