Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/qingstor: Unify pairs parsing in storager.Read #277

Closed
Prnyself opened this issue Apr 29, 2020 · 0 comments · Fixed by #283
Closed

service/qingstor: Unify pairs parsing in storager.Read #277

Prnyself opened this issue Apr 29, 2020 · 0 comments · Fixed by #283
Labels
enhancement New feature or request

Comments

@Prnyself
Copy link
Member

Prnyself commented Apr 29, 2020 •
edited
Loading

I tried to copy file between qingstor and local fs. When copy from fs, I need to set pair size by pair.WithSize. However when copy reversely (qingstor to fs), the Read method returns an insufficient error for setting pair size. So maybe we should unify the pairs in the same behavior (between different service)?
@Prnyself Prnyself changed the title service/qingstor: Read parse pairs panic service/qingstor: Unify pairs parsing in storager.Read Apr 29, 2020
@Xuanwo Xuanwo mentioned this issue May 1, 2020
Merged
@Xuanwo Xuanwo added the enhancement New feature or request label May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

services/qingstor: Allow read with offset and size beyondstorage/go-storage
2 participants
@Xuanwo @Prnyself