Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/qingstor: Allow read with offset and size #283

Merged
merged 3 commits into from
May 1, 2020

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented May 1, 2020

Signed-off-by: Xuanwo github@xuanwo.io

Close #277

Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #283 into master will decrease coverage by 0.26%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   84.68%   84.41%   -0.27%     
==========================================
  Files          12       12              
  Lines         940      943       +3     
==========================================
  Hits          796      796              
- Misses         89       91       +2     
- Partials       55       56       +1     
Impacted Files Coverage Δ
services/qingstor/storager.go 76.10% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3143c2b...030efcb. Read the comment docs.

Xuanwo added 2 commits May 1, 2020 15:59
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit aeed07c into master May 1, 2020
@Xuanwo Xuanwo deleted the feature/qingstor_read branch May 1, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

service/qingstor: Unify pairs parsing in storager.Read
1 participant