Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/*: Set content-type as best errort #234

Merged
merged 8 commits into from
Mar 27, 2020
Merged

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Mar 27, 2020

No description provided.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo linked an issue Mar 27, 2020 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #234 into master will decrease coverage by 0.28%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   84.56%   84.27%   -0.29%     
==========================================
  Files          11       12       +1     
  Lines         907      916       +9     
==========================================
+ Hits          767      772       +5     
- Misses         86       88       +2     
- Partials       54       56       +2     
Impacted Files Coverage Δ
services/fs/storager.go 86.52% <0.00%> (-1.84%) ⬇️
pkg/mime/mime.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3239e...bf2e846. Read the comment docs.

@Xuanwo Xuanwo merged commit 5cdafd6 into master Mar 27, 2020
@Xuanwo Xuanwo deleted the fix/content_type branch March 27, 2020 07:52
rgglez pushed a commit to rgglez/go-storage that referenced this pull request Oct 25, 2024
* services/azblob: Set content type

Signed-off-by: Xuanwo <github@xuanwo.io>

* services/cos: Set content type correctly

Signed-off-by: Xuanwo <github@xuanwo.io>

* pkg/mime: Add TypeByFileName support

Signed-off-by: Xuanwo <github@xuanwo.io>

* services/fs: Try to set content type

Signed-off-by: Xuanwo <github@xuanwo.io>

* services/gcs: Set content type correctly

Signed-off-by: Xuanwo <github@xuanwo.io>

* services/kodo: Set content type

Signed-off-by: Xuanwo <github@xuanwo.io>

* services/oss: Set content type

Signed-off-by: Xuanwo <github@xuanwo.io>

* services/uss: Set content type

Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

services/*: Content type should be set if available
1 participant