Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/headers: Move all explicit header keys into const #236

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Mar 27, 2020

Signed-off-by: Xuanwo github@xuanwo.io

Signed-off-by: Xuanwo <github@xuanwo.io>
@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Xuanwo Xuanwo linked an issue Mar 27, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #236 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   84.29%   84.29%           
=======================================
  Files          12       12           
  Lines         917      917           
=======================================
  Hits          773      773           
  Misses         88       88           
  Partials       56       56           
Impacted Files Coverage Δ
services/qingstor/servicer.go 77.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88bc12c...20b0b19. Read the comment docs.

@Xuanwo Xuanwo merged commit a3cfe3e into master Mar 27, 2020
@Xuanwo Xuanwo deleted the feature/add_headers branch March 27, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg: Add common header
1 participant