Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreutils, services: Refactor Open related logic #264

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Apr 23, 2020

Signed-off-by: Xuanwo github@xuanwo.io

Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #264 into master will decrease coverage by 0.11%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   84.18%   84.07%   -0.12%     
==========================================
  Files          12       12              
  Lines         936      948      +12     
==========================================
+ Hits          788      797       +9     
- Misses         92       94       +2     
- Partials       56       57       +1     
Impacted Files Coverage Δ
services/fs/utils.go 80.64% <71.42%> (+1.33%) ⬆️
services/qingstor/utils.go 83.13% <72.00%> (-1.16%) ⬇️
services/qingstor/storager.go 76.78% <93.33%> (ø)
services/fs/storager.go 87.43% <100.00%> (ø)
services/qingstor/servicer.go 77.86% <100.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7682686...df7f3de. Read the comment docs.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit 8f34c80 into master Apr 23, 2020
@Xuanwo Xuanwo deleted the feature/refactor_new branch April 23, 2020 09:03
rgglez pushed a commit to rgglez/go-storage that referenced this pull request Oct 25, 2024
* coreutils, services: Refactor Open related logic

Signed-off-by: Xuanwo <github@xuanwo.io>

* services: Move op name to const

Signed-off-by: Xuanwo <github@xuanwo.io>

* services/qingstor: Fix unit test for new storage

Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant