Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/qingstor: Detect bucket location automatically #278

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Apr 29, 2020

Signed-off-by: Xuanwo github@xuanwo.io

Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #278 into master will increase coverage by 0.32%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
+ Coverage   84.35%   84.68%   +0.32%     
==========================================
  Files          12       12              
  Lines         946      940       -6     
==========================================
- Hits          798      796       -2     
+ Misses         92       89       -3     
+ Partials       56       55       -1     
Impacted Files Coverage Δ
services/qingstor/servicer.go 80.00% <77.77%> (+2.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae37d1...54c36cc. Read the comment docs.

@Xuanwo Xuanwo merged commit 7cc37ca into master Apr 29, 2020
@Xuanwo Xuanwo deleted the feature/qingstor_auto_detect branch April 29, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant