Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Refactor definitions generator #303

Merged
merged 5 commits into from
May 7, 2020
Merged

*: Refactor definitions generator #303

merged 5 commits into from
May 7, 2020

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented May 6, 2020

Signed-off-by: Xuanwo github@xuanwo.io

Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel
Copy link

vercel bot commented May 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/xuanwo/storage-docs/gwia40y4u
✅ Preview: https://storage-docs-git-feature-servicepair.xuanwo.now.sh

Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel vercel bot had a problem deploying to Preview May 7, 2020 02:27 Failure
Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel vercel bot had a problem deploying to Preview May 7, 2020 02:32 Failure
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #303 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files          12       12           
  Lines         943      943           
=======================================
  Hits          796      796           
  Misses         91       91           
  Partials       56       56           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60c73c2...4438463. Read the comment docs.

Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel vercel bot had a problem deploying to Preview May 7, 2020 05:40 Failure
Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel vercel bot had a problem deploying to Preview May 7, 2020 05:48 Failure
@Xuanwo Xuanwo changed the title Refactor definitions generator *: Refactor definitions generator May 7, 2020
@Xuanwo Xuanwo merged commit e581b62 into master May 7, 2020
@Xuanwo Xuanwo deleted the feature/service_pair branch May 7, 2020 06:08
rgglez pushed a commit to rgglez/go-storage that referenced this pull request Oct 25, 2024
* Refactor definitions generator

Signed-off-by: Xuanwo <github@xuanwo.io>

* definitions: Fix wrong pairs

Signed-off-by: Xuanwo <github@xuanwo.io>

* services: Fix context dup

Signed-off-by: Xuanwo <github@xuanwo.io>

* internal/cmd/definitions: Support format hcl files

Signed-off-by: Xuanwo <github@xuanwo.io>

* makefile: Update clean

Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant