Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/uss: Disable async delete for unexpected behavior #345

Merged
merged 2 commits into from
May 19, 2020
Merged

services/uss: Disable async delete for unexpected behavior #345

merged 2 commits into from
May 19, 2020

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented May 19, 2020

Signed-off-by: Xuanwo github@xuanwo.io

@Xuanwo
tests: Add integration test for uss
3d0bc6b 
Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel
Copy link

vercel bot commented May 19, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/xuanwo/storage-docs/jx558t9zl
✅ Preview: https://storage-docs-git-tests-uss.xuanwo.now.sh

@Xuanwo
Copy link
Contributor Author

Xuanwo commented May 19, 2020 

  * /drone/src/tests/storager_test.go 
  Line 247:
  Expected: false
  Actual:   true
  goroutine 53 [running]:
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/reporting/reports.go:143 +0x7b
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/reporting/reports.go:103 +0xbc
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:176 +0x223
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/doc.go:125 +0x71
  github.com/Xuanwo/storage/tests.testDirLister.func1.1.3()
  	/drone/src/tests/storager_test.go:247 +0xa9
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/discovery.go:80 +0x3e
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:261 +0x21b
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:163 +0xa9
  github.com/jtolds/gls.(*ContextManager).SetValues.func1(0x0)
  	/go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/context.go:97 +0x5c5
  github.com/jtolds/gls.EnsureGoroutineId(0xc0002a29f0)
  	/go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/gid.go:19 +0x18e
  github.com/jtolds/gls.(*ContextManager).SetValues(0xc0000dc760, 0xc0002a2900, 0xc00064e4c0)
  	/go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/context.go:63 +0x26c
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:162 +0x329
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/doc.go:77 +0xb0
  github.com/Xuanwo/storage/tests.testDirLister.func1.1()
  	/drone/src/tests/storager_test.go:246 +0x3a3
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/discovery.go:80 +0x3e
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:261 +0x21b
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:163 +0xa9
  github.com/jtolds/gls.(*ContextManager).SetValues.func1(0x0)
  	/go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/context.go:97 +0x5c5
  github.com/jtolds/gls.EnsureGoroutineId(0xc0002a2150)
  	/go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/gid.go:19 +0x18e
  github.com/jtolds/gls.(*ContextManager).SetValues(0xc0000dc760, 0xc0002a20f0, 0xc00064e2a0)
  	/go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/context.go:63 +0x26c
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:162 +0x329
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/doc.go:77 +0xb0
  github.com/Xuanwo/storage/tests.testDirLister.func1()
  	/drone/src/tests/storager_test.go:234 +0x217
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/discovery.go:80 +0x3e
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:261 +0x21b
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:110 +0x1b0
  github.com/jtolds/gls.(*ContextManager).SetValues.func1(0x0)
  	/go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/context.go:97 +0x5c5
  github.com/jtolds/gls.EnsureGoroutineId.func1()
  	/go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/gid.go:24 +0x46
  github.com/jtolds/gls._m(0x0, 0xc0006884a0)
  	/go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/stack_tags.go:108 +0x43
  github.com/jtolds/gls.github_com_jtolds_gls_markS(0x0, 0xc0006884a0)
  	/go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/stack_tags.go:56 +0x43
  github.com/jtolds/gls.addStackTag(...)
  	/go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/stack_tags.go:49
  github.com/jtolds/gls.EnsureGoroutineId(0xc000a82480)
  	/go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/gid.go:24 +0x157
  github.com/jtolds/gls.(*ContextManager).SetValues(0xc0000dc760, 0xc000a82360, 0xc000688400)
  	/go/pkg/mod/github.com/jtolds/gls@v4.20.0+incompatible/context.go:63 +0x26c
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/context.go:105 +0x458
  	/go/pkg/mod/github.com/smartystreets/goconvey@v1.6.4/convey/doc.go:75 +0xe1
  github.com/Xuanwo/storage/tests.testDirLister(0xc000158200, 0xc0000410a0, 0x3, 0xc000630b20, 0x4, 0x4)
  	/drone/src/tests/storager_test.go:219 +0x17e
  github.com/Xuanwo/storage/tests.TestStorager(0xc000158200)
  	/drone/src/tests/storager_test.go:32 +0x1f4
  testing.tRunner(0xc000158200, 0x166cdb0)
  	/usr/local/go/src/testing/testing.go:909 +0x19a
  created by testing.(*T).Run
  	/usr/local/go/src/testing/testing.go:960 +0x652

@Xuanwo
Copy link
Contributor Author

Xuanwo commented May 19, 2020

Caused by async delete:

  Given a dir lister
    When List an empty dir work_dir:  /storage_test/4bb8df00-134a-48bd-963a-6373eaf2fd7f/
path: c6093f19-a72c-4fa4-9b2e-10760431fc9b, dir: %!s(bool=false)


      The error should be nil ✔work_dir:  /storage_test/4bb8df00-134a-48bd-963a-6373eaf2fd7f/
path: c6093f19-a72c-4fa4-9b2e-10760431fc9b, dir: %!s(bool=false)


      The file func should not be called ✘
    When List a dir within files work_dir:  /storage_test/4bb8df00-134a-48bd-963a-6373eaf2fd7f/
path: 1b046af5-c31c-4733-8aad-823487384092, dir: %!s(bool=false)

path: c6093f19-a72c-4fa4-9b2e-10760431fc9b, dir: %!s(bool=false)


      The error should be nil ✔work_dir:  /storage_test/4bb8df00-134a-48bd-963a-6373eaf2fd7f/
path: c6093f19-a72c-4fa4-9b2e-10760431fc9b, dir: %!s(bool=false)

path: e11563a7-5d44-4d5e-85d1-09d27a10b8f8, dir: %!s(bool=false)


      The file func should be called ✔work_dir:  /storage_test/4bb8df00-134a-48bd-963a-6373eaf2fd7f/
path: 9b8098f8-e227-4e83-a06d-0b6ce76e7f54, dir: %!s(bool=false)

path: c6093f19-a72c-4fa4-9b2e-10760431fc9b, dir: %!s(bool=false)


      The name and size should be match ✔✘

@Xuanwo
services/uss: Disable async delete for unexpected behavior
fd39aac 
Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel vercel bot had a problem deploying to Preview May 19, 2020 08:53 Failure
@Xuanwo
Copy link
Contributor Author

Xuanwo commented May 19, 2020

We will drop full uss support

@Xuanwo Xuanwo changed the title tests: Add integration test for uss services/uss: Disable async delete for unexpected behavior May 19, 2020
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #345 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files          12       12           
  Lines         948      948           
=======================================
  Hits          798      798           
  Misses         91       91           
  Partials       59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa197c...fd39aac. Read the comment docs.

@Xuanwo Xuanwo merged commit 7247a7f into master May 19, 2020
@Xuanwo Xuanwo deleted the tests/uss branch May 19, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Xuanwo