Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add test for NewStoragerFromString #724

Merged
merged 1 commit into from
Aug 26, 2021
Merged

tests: Add test for NewStoragerFromString #724

merged 1 commit into from
Aug 26, 2021

Conversation

JinnyYi
Copy link
Contributor

@JinnyYi JinnyYi commented Aug 25, 2021

No description provided.

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #724 (17931b4) into master (841f5c1) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
+ Coverage   12.36%   12.55%   +0.19%     
==========================================
  Files          22       22              
  Lines        1488     1473      -15     
==========================================
+ Hits          184      185       +1     
+ Misses       1297     1281      -16     
  Partials        7        7              
Flag Coverage Δ
unittests 12.55% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/storage.go 0.00% <ø> (ø)
tests/utils.go 33.33% <100.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841f5c1...17931b4. Read the comment docs.

@JinnyYi JinnyYi changed the title tests: Add test for NewStorageFromString tests: Add test for NewStoragerFromString Aug 25, 2021
@Xuanwo
Copy link
Contributor

Xuanwo commented Aug 26, 2021

Great work!

@Xuanwo Xuanwo merged commit b6c58a8 into master Aug 26, 2021
@Xuanwo Xuanwo deleted the connstr-test branch August 26, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants