Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSP-752: Adopt commitizen/conventional-commit-types #752

Closed
wants to merge 4 commits into from

Conversation

JinnyYi
Copy link
Contributor

@JinnyYi JinnyYi commented Sep 10, 2021

ref: #744

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #752 (405cb86) into master (5e5d191) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #752   +/-   ##
=======================================
  Coverage   12.34%   12.34%           
=======================================
  Files          22       22           
  Lines        1434     1434           
=======================================
  Hits          177      177           
  Misses       1250     1250           
  Partials        7        7           
Flag Coverage Δ
unittests 12.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5d191...405cb86. Read the comment docs.

@JinnyYi JinnyYi changed the title Proposal: Adopt commitizen/conventional-commit-types GSP-752: Adopt commitizen/conventional-commit-types Sep 17, 2021
@Xuanwo
Copy link
Contributor

Xuanwo commented Sep 22, 2021

Maybe this rule should be applied to the whole community?

@Xuanwo
Copy link
Contributor

Xuanwo commented Sep 22, 2021

Let's defer this proposal for further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants