Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Update dependencies. #222

Merged
merged 1 commit into from
Nov 11, 2019
Merged

[2.x] Update dependencies. #222

merged 1 commit into from
Nov 11, 2019

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Nov 3, 2019

DO NOT MERGE

I will update it when we have a new asset-resolver version :)

Would be nice if we could drop more dependencies in this branch too. If you are going to do this @bezoerb please ping me before cutting a new 2.x release; we need to test once with Node.js 6.0.0 to make sure we don't break something.

@XhmikosR XhmikosR changed the title [2.x] Remove unused dependencies and replace one with a native solution. [2.x] Update dependencies. Nov 10, 2019
@XhmikosR XhmikosR marked this pull request as ready for review November 10, 2019 05:33
@XhmikosR
Copy link
Contributor Author

Actually, do not merge this, I need to update this after the asset-resolver 1.x fix is published.

Also, remove unused ones and replace one with a native solution.
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Nov 11, 2019

@bezoerb this is ready. You can review, merge and release a new version.

@bezoerb bezoerb merged commit b943218 into bezoerb:v2.x Nov 11, 2019
@XhmikosR XhmikosR deleted the v2.x branch November 11, 2019 10:12
@XhmikosR
Copy link
Contributor Author

@bezoerb don't forget to release a new patch version :) BTW I tested this with Node.js 6.0.0 and it passed.

@bezoerb
Copy link
Owner

bezoerb commented Nov 11, 2019

:) Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants