Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define OSPLAT for riscv64 and riscv32 #341

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

kxxt
Copy link
Contributor

@kxxt kxxt commented Oct 20, 2023

Proposed changes

Define OSPLAT for riscv64 and riscv32. Fixes boostorg/context#243 #340

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I searched the discussions
  • I searched the closed and open issues
  • I read the contribution guidelines
  • I added myself to the copyright attributions for significant changes
  • I checked that tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • I added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

kxxt added a commit to kxxt/archriscv-packages that referenced this pull request Oct 20, 2023
Fix missing asm functions in boost context lib.

Upstream bugs:

- boostorg/context: boostorg/context#243
- b2: bfgroup/b2#340

Upstream PR: bfgroup/b2#341
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Oct 20, 2023
Fix missing asm functions in boost context lib.

Upstream bugs:

- boostorg/context: boostorg/context#243
- b2: bfgroup/b2#340

Upstream PR: bfgroup/b2#341
@olk
Copy link

olk commented Oct 23, 2023

On older compiler __riscv__ is defined - maybe this should be checked too.

* src/engine/jam.h
    define OSPLAT for riscv64 and riscv32
@kxxt
Copy link
Contributor Author

kxxt commented Oct 23, 2023

On older compiler __riscv__ is defined - maybe this should be checked too.

Thanks! I have updated it.

@grafikrobot grafikrobot merged commit b4c09d1 into bfgroup:main Dec 1, 2023
121 checks passed
aimixsaka added a commit to aimixsaka/archriscv-packages that referenced this pull request Dec 18, 2023
- fix patch(bfgroup/b2#341) hash,
  (this patch is still required)
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Dec 18, 2023
- fix patch(bfgroup/b2#341) hash,
  (this patch is still required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asm parts are not compiled when building boost 1.83 on riscv64 linux
3 participants