sort datasource keys for idempotence #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see on this line https://github.com/bfraser/puppet-grafana/blob/master/templates/config.js.erb#L13 a
.sort
being called. I assume this is to keep the order of the hash consistent so that writes toconfig.js
are idempotent.however, my Puppet Reports are full of these:
an additional
.sort
is required to sort the datasources as well as the contents of each datasource.