-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more customizations in config.js #3
Conversation
This is a preparation to include that in the config-template.
this way, users can choose their own settings more easily.
Thanks for the pull request. URLI think the easiest and most effective way to give the user flexibility and control over the Graphite, Elasticsearch and InfluxDB URLs is to simply provide a TemplateI understand your desire to have more control over the template. Perhaps, rather than parameterizing the template file to use, the existing template can be made better. My thinking was to introduce boolean parameters that control whether Would these changes provide sufficient coverage for your use case, or do you still see a need for Thanks! |
The change you propose would be sufficient as well. I will try to come up with something later today and update this PR accordingly. |
There, I fixed it ;-) |
This should make Travis happy. |
Ah, finally green. By now I must have touched almost all files of the module :-) What do you think of the changes, @bfraser ? |
I'll try to have a look at this later today. Thanks for the diligence :-) |
Sorry, I haven't had a chance to get to this yet. Probably not until the weekend. |
No problem. I'm using my own fork in the meantime. I just meant to be a good open-source citizen, not to stress you out. If you spot more problems, just say it. For now, I'm just happy that it works the way I want :-) |
FYI, I little bit more flexible implementation for datasources - #4 |
That looks great, @analogue. I will update this PR to only cover the |
Closing this out as the module now works with Grafana 2.x and there no longer is a config.js to manage. |
👍 |
* initial commit to implement grafana_folder resource type * add required parameters for grafana objects * remove references to dashboard objects (dashboard used as template) * update tests * remove whitespace for rubocop * rubocop fixes * fix global var assignment clause logic * update README.md/created acceptance test for grafana_folder resource
* initial commit to implement grafana_folder resource type * add required parameters for grafana objects * remove references to dashboard objects (dashboard used as template) * update tests * remove whitespace for rubocop * rubocop fixes * fix global var assignment clause logic * update README.md/created acceptance test for grafana_folder resource
Background and Motivation
Grafana can be configure in many different ways, but the basic setup is always the same.
In order to use your module,
I want to pass in my own config-template
But still use the class to define the essential bits from the manifest.
Implementation
I added
*_scheme
-parameters forgraphite
,elasticsearch
, andinfluxdb
. I have Graphite and ElasticSearch running on a https-host, so I need that ability.I also do not use InfluxDB, so I made the config-template overridable. This allows me to use our own template. In the template, I can still use the parameters defined in the class.
Side effects
Having the template overridable is essentially giving people enough rope to hang themselves. Then again, the target audience is admins and devops-teams, so we're all capable of handling this.