Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add token icons & remove optimism goerli #378

Merged
merged 18 commits into from
Feb 26, 2024
Merged

Conversation

sakulstra
Copy link
Collaborator

@sakulstra sakulstra commented Feb 21, 2024

TODO:

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
address-book ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2024 1:54pm

@sakulstra sakulstra marked this pull request as draft February 21, 2024 13:22
@@ -0,0 +1,75 @@
import {join} from 'path';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's probably a nicer way to do this via xml manipulation.

Generally the approach is though:

  • have a template <svg><g>wrapper</g><g><template /></g></svg> with a fixed size (in this case made it 48)
  • replace the <template />with the inner icon and change the attributes so that size is slightly smaller then the wrapper 40in that case and adjust the offsets accordingly (by moving x and y to 4) so it's still centered.

@sakulstra sakulstra marked this pull request as ready for review February 26, 2024 13:55
@sakulstra sakulstra changed the title feat: add token icons feat: add token icons & remove optimism goerli Feb 26, 2024
@sakulstra sakulstra merged commit ec6a679 into main Feb 26, 2024
4 checks passed
@sakulstra sakulstra deleted the feat/token-icons branch February 26, 2024 13:55
sakulstra added a commit that referenced this pull request Feb 27, 2024
---------

Co-authored-by: K.K <m@mnm.mn>

fix: upload ci
sakulstra added a commit that referenced this pull request Feb 28, 2024
---------

Co-authored-by: K.K <m@mnm.mn>

fix: upload ci

fix: upload to quicknode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants