-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add token icons & remove optimism goerli #378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
sakulstra
commented
Feb 22, 2024
@@ -0,0 +1,75 @@ | |||
import {join} from 'path'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's probably a nicer way to do this via xml manipulation.
Generally the approach is though:
- have a template
<svg><g>wrapper</g><g><template /></g></svg>
with a fixed size (in this case made it48
) - replace the
<template />
with the inner icon and change the attributes so that size is slightly smaller then the wrapper40
in that case and adjust the offsets accordingly (by moving x and y to 4) so it's still centered.
* feat: update underlying icons & generator config * feat: update icons
sakulstra
changed the title
feat: add token icons
feat: add token icons & remove optimism goerli
Feb 26, 2024
sakulstra
added a commit
that referenced
this pull request
Feb 27, 2024
--------- Co-authored-by: K.K <m@mnm.mn> fix: upload ci
sakulstra
added a commit
that referenced
this pull request
Feb 28, 2024
--------- Co-authored-by: K.K <m@mnm.mn> fix: upload ci fix: upload to quicknode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: