Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff add -y parameter #1555

Merged
merged 11 commits into from
Dec 9, 2024
Merged

Diff add -y parameter #1555

merged 11 commits into from
Dec 9, 2024

Conversation

RZ9082
Copy link
Contributor

@RZ9082 RZ9082 commented Dec 4, 2024

We should still consider making the HTML report to be dependent of -y and -unified in my opinion.

@bgruening
Copy link
Owner

We should still consider making the HTML report to be dependent of -y and -unified in my opinion.

Not sure what this means, but please do :)
or in the next version?

tools/diff/diff.xml Outdated Show resolved Hide resolved
@RZ9082
Copy link
Contributor Author

RZ9082 commented Dec 4, 2024

We should still consider making the HTML report to be dependent of -y and -unified in my opinion.

Not sure what this means, but please do :) or in the next version?

in the next version, will be adding also other arguments..

@bgruening
Copy link
Owner

Do you know why diff raises a non 0 error code? You can also do diff ---fooo | true I think. But its a hack, better to figure put why diff is behaving like that.

@RZ9082
Copy link
Contributor Author

RZ9082 commented Dec 9, 2024

Do you know why diff raises a non 0 error code? You can also do diff ---fooo | true I think. But its a hack, better to figure put why diff is behaving like that.

when files do not differ the diff tool returns exit code 0, when they do differ it exits with code 1. exit code 2 would mean an error.

@wm75
Copy link
Collaborator

wm75 commented Dec 9, 2024

would be good to add a comment like that above the line of code

@bgruening
Copy link
Owner

uha interesting, why did this not fail us before? Thanks @RZ9082 for figuring this out!

@bgruening
Copy link
Owner

Ah, that was the reason the profile did not work. Cool!

Please add this as a comment and we can merge :)

@RZ9082
Copy link
Contributor Author

RZ9082 commented Dec 9, 2024

Ah, that was the reason the profile did not work. Cool!

Please add this as a comment and we can merge :)

Exactly.
Comment added. Thanks!

@bgruening bgruening enabled auto-merge (squash) December 9, 2024 14:19
@bgruening bgruening merged commit 1a6c4a7 into bgruening:master Dec 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants