sort sub-benchmarks by name (fixes #179) #180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sorts the sub-benchmarks by name when generating an HTML report, resolving #179 (assuming you agree that we should fix that! I know that this PR is putting the cart before the horse, as we haven't had any discussion in that issue yet, but I figured it would be a small change, and I wanted to familiarize myself with the codebase).
Note that CONTRIBUTING suggests to run
cargo +nightly fmt
, but that currently fails for me with:Which is rust-lang/rustfmt#2743. However, I don't foresee any formatting issues with this small (two-line) change. And in any case rustfmt makes a bunch of other changes to the code before panicking, so it looks like the codebase hasn't been getting formatted lately (or at least not with recent versions of rustfmt!).