Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: add cache-sim argument (fix issue 34) #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sigaloid
Copy link

@sigaloid sigaloid commented Jun 1, 2023

Fixes #34.

If you want to use this before it gets merged, replace your iai line in Cargo.toml to this:

iai = { git = "https://github.com/sigaloid/iai", rev = "d56a597" }

@niklasf
Copy link

niklasf commented Jun 1, 2023

Confirmed that this fixes the issue (and stats appear to be unchanged).

niklasf added a commit to niklasf/shakmaty that referenced this pull request Jun 10, 2023
@bluebear94
Copy link

I am still getting a ‘no entry found for key’ panic with d56a597.

@sigaloid
Copy link
Author

sigaloid commented Jul 3, 2023

What version of valgrind are you on? And is it pointing to my fork in your Cargo.toml?

Strange that it still wouldn't work, as that's the only cause :(

@bluebear94
Copy link

What version of valgrind are you on? And is it pointing to my fork in your Cargo.toml?

3.21.0, and yes, I removed Cargo.lock to make sure it was picking it up, and it still panics.

@msrd0
Copy link

msrd0 commented Sep 3, 2023

I can confirm the problem noticed by @bluebear94, I still get the error. Also, I found the following in the cargo output, verifying that this PR is used:

   Compiling iai v0.1.1 (https://github.com/sigaloid/iai?rev=d56a597#d56a5971)

@KonradHoeffner
Copy link

KonradHoeffner commented Sep 12, 2023

I needed a cargo update but afterwards it worked with iai = { git = "https://github.com/sigaloid/iai", rev = "d56a597" }.

@KonradHoeffner
Copy link

@sigaloid: I am relying on your bugfix in the HDT library on crates.io but depending on a GitHub repository is making me nervous.
As the main developer of this project, @bheisler has been inactive for the last 2 and a half years and I could not find any contact information, it seems to me as if this won't get merged in the near future.
Could you consider publishing your fork on crates.io, so other crates can reliably depend on a fixed version of iai?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panics with no entry found for key since valgrind 3.21.0
5 participants