Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump adjust-sourcemap-loader dependency #172

Merged
merged 1 commit into from
Oct 20, 2020
Merged

bump adjust-sourcemap-loader dependency #172

merged 1 commit into from
Oct 20, 2020

Conversation

bholloway
Copy link
Owner

removes object-path

@bholloway
Copy link
Owner Author

bholloway commented Oct 20, 2020 •
edited
Loading

Run e2e tests

  • MacOS
  • Windows

@bholloway bholloway self-assigned this Oct 20, 2020
@iwantwin
Copy link

Fixes #170
Duplicate of #171

@bholloway bholloway mentioned this pull request Oct 20, 2020
Closed
@bholloway
Copy link
Owner Author

This may have an unintended consequence of moving the minimum node version to 8.9 which is what adjust-sourcemap-loader is now requiring. Although I do not intend to explicitly move the minimum node version here.

@crudo
Copy link

crudo commented Oct 20, 2020

You are right, but node version 6 has reached end of life in April 2019.

@malkrad malkrad mentioned this pull request Oct 20, 2020
Closed
@kachkaev kachkaev mentioned this pull request Oct 20, 2020
Closed
@bholloway bholloway merged commit 4702ae9 into master Oct 20, 2020
@bholloway bholloway deleted the bump-adjust-sourcemap-loader branch October 20, 2020 09:50
@florianeckerstorfer florianeckerstorfer mentioned this pull request Oct 20, 2020
Closed
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bholloway bholloway

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bholloway @iwantwin @crudo