Skip to content

Commit

Permalink
docs(bigtable): Add todos
Browse files Browse the repository at this point in the history
  • Loading branch information
bhshkh committed Dec 12, 2024
1 parent 46fc993 commit cf414dd
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions bigtable/bigtable.go
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,10 @@ func NewClientWithConfig(ctx context.Context, project, instance string, config C
o = append(o, internaloption.AllowNonDefaultServiceAccount(true))
o = append(o, opts...)

// TODO(b/372244283): Remove after b/358175516 has been fixed
asyncRefreshMetricAttrs := metricsTracerFactory.clientAttributes
asyncRefreshMetricAttrs = append(asyncRefreshMetricAttrs,
attribute.String(metricLabelKeyTag, "async_refresh_dry_run"),

// Table, cluster and zone are unknown at this point
// Use default values
attribute.String(monitoredResLabelKeyTable, defaultTable),
Expand All @@ -140,9 +140,10 @@ func NewClientWithConfig(ctx context.Context, project, instance string, config C
metricsTracerFactory.debugTags.Add(context.Background(), 1,
metric.WithAttributes(asyncRefreshMetricAttrs...))
}))

connPool, err := gtransport.DialPool(ctx, o...)
if err != nil {
return nil, fmt.Errorf("dialing: %w", err)
return nil, err
}

return &Client{
Expand Down

0 comments on commit cf414dd

Please sign in to comment.