Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor editorial nits #263

Closed
franciscave opened this issue May 28, 2020 · 2 comments · Fixed by #264
Closed

Minor editorial nits #263

franciscave opened this issue May 28, 2020 · 2 comments · Fixed by #264
Assignees
@franciscave
Labels
Erratum
Milestone
1.3.0

Comments

@franciscave
Copy link
Collaborator

In the Data Framework, E14 Library Authority / Institution, the open time-period elements have incorrect IDs: "E15" should be "E14" in four places.
@franciscave franciscave added this to the Someday.Patch milestone May 28, 2020
@franciscave franciscave self-assigned this May 28, 2020
franciscave added a commit that referenced this issue May 28, 2020
@franciscave
Update LCF-DataFrameworks.md
4d49a4d 
Corrected property IDs in E14. See issue #263.
@franciscave franciscave mentioned this issue May 28, 2020
Merged
@franciscave
Copy link
Collaborator Author

I have noticed that some composite elements are not italicised according to the established style convention, and am fixing that.

@franciscave
Copy link
Collaborator Author

In the REST implementation there's an error in the element ID for a loan entity in the check-out response. 'R12C09' should be 'R11C02'. I'm fixing that, along with some styling inconsistencies in the REST implementation.

@mdovey mdovey closed this as completed Oct 20, 2020
@anthonywhitford anthonywhitford modified the milestones: Someday.Patch, 1.3.0 Apr 3, 2024
@anthonywhitford anthonywhitford linked a pull request Apr 3, 2024 that will close this issue
Update LCF-DataFrameworks.md #264
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franciscave franciscave

Labels
Erratum
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Update LCF-DataFrameworks.md bic-org-uk/bic-lcf
3 participants
@mdovey @anthonywhitford @franciscave