Update master #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MNT: Relax line length limit in YAML * MNT: Ignore pycache in tools dir * CI: Update configuration based on Travis validator Also bump Python version and cache pip
* Add derivatives entities. * Apply suggestions from code review Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Differentiate derivative entities from raw entities. * Update entities page. Co-authored-by: Chris Markiewicz <effigies@gmail.com>
* Add part entity. * Add self to contributors file. * Address @yarikoptic's review. * Fix entity table spacing. * Add missing OPTIONAL for part under func (bold phase). * Fix spacing again. * Remove OPTIONAL under func (bold phase). Wasn't missing. * Fix entity order (part goes after run). * Fix typo. * Incorporate part into schema. * Update definition and examples to match BEP001. * Fix code snippets. * Fix filename patterns now that real/imag is supported. * Apply suggestions from code review - Change radians to rad. - Treat `part` like `run`. Can only be omitted if only magnitude image is provided. Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Support part with BOLD and update entity table. * Update src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Update entity table and entity definitions. * Add link in text. * Remove section header. * Address review. * Update src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md * Deprecate phase suffix. * Fix link. * Fix link again. * Include deprecation in table. * Fix table. * Update 01-magnetic-resonance-imaging-data.md * Apply suggestions from code review Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Add entity field. * Fix bug and generate appendix. * Fix table. * Update src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Improve part definition. Co-authored-by: Chris Markiewicz <effigies@gmail.com> Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
* [ENH] Add flip entity - Modify `echo` entity respectively * revert entities.md and update the schema * Use schema tools * [FIX] Format field * Update src/schema/entities.yaml Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Update src/schema/entities.yaml Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Wording suggestion by @tsalo * [ENH] Add flip entity - Modify `echo` entity respectively * revert entities.md and update the schema * Use schema tools * [FIX] Format field * Update src/schema/entities.yaml Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Update src/schema/entities.yaml Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Wording suggestion by @tsalo Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull the latest upstream.