-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-organizing suffix section and other improvements [WIP] #59
base: master
Are you sure you want to change the base?
Conversation
- Add explanation about JSON files accompanying grouping suffixes and qMRI maps - Create a list for method-specific metadata priority levels - Create a list for qMRI methods inheritence
src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md
Outdated
Show resolved
Hide resolved
@Gilles86 and I are reviewing this PR and although we can see the benefits of not having to write out the same metadata over and over, we both agree that this proposal breaks the inheritance principle and ends up being much more complicated to implement 😭 I've deleted it for now....sorry @agahkarakuzu! I hope that's ok 😬 |
* Improve introductory text * Add two columns to clearly describe REQUIRED and OPTIONAL naming entities for grouping suffixes * Add GRASE * Add rfphase to the indexable_metadata list.
* Make it simpler
suffix
suffix
justification section w.r.t. thesuffix
classes.suffix
.MPM
&MTS
convention.Re-structure
suffix
section in the specification: Created 3 classesUpdated tables and explanations wrt 3 classes
Added rules for
grouping suffix
,indexable_metadata
andacq-<label>
Added new text for elaborating on JSON files accompanying
grouping suffixes
grouping suffixes
with metadata fieldsparent
&child
TO BE CHANGED intohigh
&low
level, or some other proper pairsession-<>
into account in the explanation of the higher level JSON forgrouping suffix
B1DAM
suffix.indexable_metadata
,acq
and JSON fields.