Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review of example that Arno shared #9

Open
robertoostenveld opened this issue Sep 19, 2023 · 8 comments
Open

review of example that Arno shared #9

robertoostenveld opened this issue Sep 19, 2023 · 8 comments

Comments

@robertoostenveld
Copy link
Collaborator

On https://drive.google.com/drive/folders/1UepEeZ80wpPxU-OhmiR9oGphomwRR2oX @arnodelorme shared an example derivative EEG dataset. This issue serves to share comments on that draft dataset.

@robertoostenveld
Copy link
Collaborator Author

also tagging @dungscout96 who was involved in the construction of the example.

@robertoostenveld
Copy link
Collaborator Author

the directory structure is

ds004117der
├── ds004117der
│   ├── sub-001
│   │   └── ses-01
│   │       └── eeg
│   ├── sub-002
│   │   └── ses-01
│   │       └── eeg

where I guess the top-level directory is the raw, and the folder inside it is the derivative. However, there should be a derivative folder level in between like this

ds004117raw
├── derivatives
|   └── ds004117der

See https://bids-specification.readthedocs.io/en/stable/02-common-principles.html#source-vs-raw-vs-derived-data

@robertoostenveld
Copy link
Collaborator Author

according to https://bids-specification.readthedocs.io/en/stable/05-derivatives/01-introduction.html#file-naming-conventions I think the derivative data should be distinguished from the raw data by a desc-<label> entity.

@robertoostenveld
Copy link
Collaborator Author

there is no descriptions.tsv file as discussed in #8

@robertoostenveld
Copy link
Collaborator Author

Regarding the directory structure, I am not sure whether my assumption at #9 (comment) holds. It rather seems that there is a copy of the same directory in the directory, and that both are derived. The metadata seems to be exactly the same, including the GeneratedBy in the dataset_description.json

@arnodelorme
Copy link
Collaborator

The folder in the subfolder was an issue associated with copying the data to Google Drive. I have removed the subfolder. I was under the impression that the inclusion of the raw data was not mandatory.

@arnodelorme
Copy link
Collaborator

arnodelorme commented Sep 19, 2023

I have updated the data (see the link above) - I have also removed the data itself to make it lightweight.

@effigies
Copy link

the inclusion of the raw data was not mandatory.

Correct. If the dataset has "DatasetType": "derivative" in its dataset_description.json, then it would be recognized as a standalone derivative dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants