Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move and rename IntendedFor field from fieldmap to functional image #39

Open
tsalo opened this issue Aug 3, 2020 · 2 comments
Open

Move and rename IntendedFor field from fieldmap to functional image #39

tsalo opened this issue Aug 3, 2020 · 2 comments
Labels
impact: medium Estimated medium impact change metadata Changes to metadata fields/files.

Comments

@tsalo
Copy link
Member

tsalo commented Aug 3, 2020

Under the current BIDS Specification, the field defining which fieldmaps are associated with each epi image are defined in the fieldmap. Accessing this information requires some kind of backwards logic and searching through all fieldmap metadata to find which ones correspond to a given file, my solution to this is moving the field to the epi image metadata in a new field like AssociatedFieldmaps or AssociatedDistortionmaps, meaning the information as to which fieldmap is associated with each image is easily accessible by calling that epi images metadata.

Original authors: @akimbler
@tsalo tsalo changed the title Move and Rename IntendedFor field from fieldmap to functional image Move and rename IntendedFor field from fieldmap to functional image Aug 3, 2020
@tsalo tsalo added metadata Changes to metadata fields/files. impact: medium Estimated medium impact change labels Aug 3, 2020
@jbteves
Copy link

jbteves commented Aug 4, 2020

I would like to agree in particular with using the field name

AssociatedDistortionMap

@oesteban oesteban mentioned this issue Sep 15, 2020
Closed
2 tasks
oesteban added a commit to oesteban/bids-specification that referenced this issue Sep 28, 2020
@oesteban
enh: allow encoding the fieldmapping intent of the protocol
f03374c 
This PR addresses the problem @mattcieslak spotted at in bids-standard#239.

This enhancement (WIP) basically allows for researchers to encode
the protocol's intent regarding fieldmaps.

As @satra introduced in bids-standard#239 (comment),
BIDS "*could encode intent and automation. Whether it should is a community decision."

This PR proposes a solution to encoding the intent. It doesn't modify
anything to allow also encoding automation.

The PR attempts to be backwards compatible.

I'm submitting this draft PR to open discussions and looking forward to
feedback.

Resolves: bids-standard#239.
References: #263, nipreps/dmriprep#43, bids-standard/bids-2-devel#39
@oesteban oesteban mentioned this issue Sep 28, 2020
Merged
oesteban added a commit to oesteban/bids-specification that referenced this issue Oct 23, 2020
@oesteban
enh: allow encoding the fieldmapping intent of the protocol
c5f5ea8 
This PR addresses the problem @mattcieslak spotted at in bids-standard#239.

This enhancement (WIP) basically allows for researchers to encode
the protocol's intent regarding fieldmaps.

As @satra introduced in bids-standard#239 (comment),
BIDS "*could encode intent and automation. Whether it should is a community decision."

This PR proposes a solution to encoding the intent. It doesn't modify
anything to allow also encoding automation.

The PR attempts to be backwards compatible.

I'm submitting this draft PR to open discussions and looking forward to
feedback.

Resolves: bids-standard#239.
References: #263, nipreps/dmriprep#43, bids-standard/bids-2-devel#39
oesteban added a commit to oesteban/bids-specification that referenced this issue Oct 23, 2020
@oesteban
enh: allow encoding the fieldmapping intent of the protocol
953ed10 
This PR addresses the problem @mattcieslak spotted at in bids-standard#239.

This enhancement (WIP) basically allows for researchers to encode
the protocol's intent regarding fieldmaps.

As @satra introduced in bids-standard#239 (comment),
BIDS "*could encode intent and automation. Whether it should is a community decision."

This PR proposes a solution to encoding the intent. It doesn't modify
anything to allow also encoding automation.

The PR attempts to be backwards compatible, and is based off of bids-standard#651,
where the text about fieldmaps is being revised.

I'm submitting this draft PR to open discussions and looking forward to
feedback.

Resolves: bids-standard#239.
Depends: bids-standard#651.
References: #263, nipreps/dmriprep#43, bids-standard/bids-2-devel#39
oesteban added a commit to oesteban/bids-specification that referenced this issue Oct 26, 2020
@oesteban
enh: allow encoding the fieldmapping intent of the protocol
f96c0c9 
This PR addresses the problem @mattcieslak spotted at in bids-standard#239.

This enhancement (WIP) basically allows for researchers to encode
the protocol's intent regarding fieldmaps.

As @satra introduced in bids-standard#239 (comment),
BIDS "*could encode intent and automation. Whether it should is a community decision."

This PR proposes a solution to encoding the intent. It doesn't modify
anything to allow also encoding automation.

The PR attempts to be backwards compatible, and is based off of bids-standard#651,
where the text about fieldmaps is being revised.

I'm submitting this draft PR to open discussions and looking forward to
feedback.

Resolves: bids-standard#239.
Depends: bids-standard#651.
References: #263, nipreps/dmriprep#43, bids-standard/bids-2-devel#39
oesteban added a commit to oesteban/bids-specification that referenced this issue Oct 26, 2020
@oesteban
enh: allow encoding the fieldmapping intent of the protocol
70ba519 
This PR addresses the problem @mattcieslak spotted at in bids-standard#239.

This enhancement (WIP) basically allows for researchers to encode
the protocol's intent regarding fieldmaps.

As @satra introduced in bids-standard#239 (comment),
BIDS "*could encode intent and automation. Whether it should is a community decision."

This PR proposes a solution to encoding the intent. It doesn't modify
anything to allow also encoding automation.

The PR attempts to be backwards compatible, and is based off of bids-standard#651,
where the text about fieldmaps is being revised.

I'm submitting this draft PR to open discussions and looking forward to
feedback.

Resolves: bids-standard#239.
Depends: bids-standard#651.
References: #263, nipreps/dmriprep#43, bids-standard/bids-2-devel#39
oesteban added a commit to oesteban/bids-specification that referenced this issue Oct 28, 2020
@oesteban
enh: allow encoding the fieldmapping intent of the protocol
e39f500 
This PR addresses the problem @mattcieslak spotted at in bids-standard#239.

This enhancement (WIP) basically allows for researchers to encode
the protocol's intent regarding fieldmaps.

As @satra introduced in bids-standard#239 (comment),
BIDS "*could encode intent and automation. Whether it should is a community decision."

This PR proposes a solution to encoding the intent. It doesn't modify
anything to allow also encoding automation.

The PR attempts to be backwards compatible, and is based off of bids-standard#651,
where the text about fieldmaps is being revised.

I'm submitting this draft PR to open discussions and looking forward to
feedback.

Resolves: bids-standard#239.
Depends: bids-standard#651.
References: #263, nipreps/dmriprep#43, bids-standard/bids-2-devel#39
oesteban added a commit to oesteban/bids-specification that referenced this issue Oct 28, 2020
@oesteban
enh: allow encoding the fieldmapping intent of the protocol
57f338e 
This PR addresses the problem @mattcieslak spotted at in bids-standard#239.

This enhancement (WIP) basically allows for researchers to encode
the protocol's intent regarding fieldmaps.

As @satra introduced in bids-standard#239 (comment),
BIDS "*could encode intent and automation. Whether it should is a community decision."

This PR proposes a solution to encoding the intent. It doesn't modify
anything to allow also encoding automation.

The PR attempts to be backwards compatible, and is based off of bids-standard#651,
where the text about fieldmaps is being revised.

I'm submitting this draft PR to open discussions and looking forward to
feedback.

Resolves: bids-standard#239.
Depends: bids-standard#651.
References: #263, nipreps/dmriprep#43, bids-standard/bids-2-devel#39
oesteban added a commit to oesteban/bids-specification that referenced this issue Nov 6, 2020
@oesteban
enh: allow encoding the fieldmapping intent of the protocol
eeec0bb 
This PR addresses the problem @mattcieslak spotted at in bids-standard#239.

This enhancement (WIP) basically allows for researchers to encode
the protocol's intent regarding fieldmaps.

As @satra introduced in bids-standard#239 (comment),
BIDS "*could encode intent and automation. Whether it should is a community decision."

This PR proposes a solution to encoding the intent. It doesn't modify
anything to allow also encoding automation.

The PR attempts to be backwards compatible, and is based off of bids-standard#651,
where the text about fieldmaps is being revised.

I'm submitting this draft PR to open discussions and looking forward to
feedback.

Resolves: bids-standard#239.
Depends: bids-standard#651.
References: #263, nipreps/dmriprep#43, bids-standard/bids-2-devel#39
oesteban added a commit to oesteban/bids-specification that referenced this issue Apr 5, 2021
@oesteban
enh: allow encoding the fieldmapping intent of the protocol
c44b926 
This PR addresses the problem @mattcieslak spotted at in bids-standard#239.

This enhancement (WIP) basically allows for researchers to encode
the protocol's intent regarding fieldmaps.

As @satra introduced in bids-standard#239 (comment),
BIDS "*could encode intent and automation. Whether it should is a community decision."

This PR proposes a solution to encoding the intent. It doesn't modify
anything to allow also encoding automation.

The PR attempts to be backwards compatible, and is based off of bids-standard#651,
where the text about fieldmaps is being revised.

I'm submitting this draft PR to open discussions and looking forward to
feedback.

Resolves: bids-standard#239.
Depends: bids-standard#651.
References: #263, nipreps/dmriprep#43, bids-standard/bids-2-devel#39
@tsalo
Copy link
Member Author

tsalo commented May 17, 2022

Given that bids-standard/bids-specification#622 was merged into the specification, I think this proposal could be amended to "Remove IntendedFor field in favor of B0FieldIdentifier and B0FieldSource".

@Lestropie Lestropie mentioned this issue Aug 8, 2022
Open
@yarikoptic yarikoptic mentioned this issue Mar 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact: medium Estimated medium impact change metadata Changes to metadata fields/files.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsalo @jbteves