Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Preprocessed diffusion-weighted images"? #25

Open
Lestropie opened this issue Nov 16, 2021 · 3 comments
Open

Remove "Preprocessed diffusion-weighted images"? #25

Lestropie opened this issue Nov 16, 2021 · 3 comments

Comments

@Lestropie
Copy link
Collaborator

  • Consider removing example pre-processed DWIs: should be covered by common derivatives

  • Consider removing reserved JSON metadata fields, as these relate to provenance and responsibility for such should be deferred elsewhere

@Lestropie
Copy link
Collaborator Author

Options:

  1. Remove "Pre-processed diffusion-weighted images" section entirely.

    Appropriate formatting of pre-processed DWI data would need to be inferred based on existing contents of the specification; e.g. file name can't be identical to the corresponding BIDS Raw file; .bvecs & .bvals are requisite.

    JSON reserved keywords based on preprocessing would be omitted. Software tools would be free to insert any information they wish into the JSON, but there would be no established dictionary of such, noting that the current example dictionary relates entirely to provenance, for which we are seeking to defer responsibility.

  2. Instead provide an "example" of what pre-processed DWI might look like; e.g. could make "_desc-preproc" a RECOMMENDED. The current text jumps straight into "Multiple different versions of preprocessing can be stored for the same source data", which is an edge use case and would be the one time that the "_desc-preproc" recommendation would not suffice.

    Even if taking this option, I would personally still be recommending to omit the JSON reserved keywords.

@arokem
Copy link
Collaborator

arokem commented Nov 22, 2021

I like number 2 a bit better, as I think that it eases a reader of the spec into things more gradually. I agree that we would want to omit the JSON keywords, since that is indicative of provenance.

Lestropie added a commit that referenced this issue Nov 23, 2021
- Provide basic instructions rather than elaborating on rare use cases.
- Remove JSON dictionary on preprocessing steps utilised as these relate to provenance and are therefore out of scope.
Proposal for addressing #25.
@neurolabusc
Copy link

If the section is retained, the filename extensions .bvecs and .bvals should be renamed .bvec and .bval to be consistent with the existing BIDS specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants