Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump bids-validator version #170

Merged
merged 13 commits into from
Dec 3, 2019
Merged

bump bids-validator version #170

merged 13 commits into from
Dec 3, 2019

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Oct 17, 2019

somehow bumping the nodejs version and BIDS validator version up to the most recent one leads to a breakage :-)

any idea why @rwblair ?

@rwblair
Copy link
Member

rwblair commented Oct 17, 2019

Wasn't able to recreate locally with node 10.11 and 1.3.6 validator. I'll poke around travis and see if I can figure anything out.

That was a lie, turns out I could recreate the issue, also with the 1.3.8 validator.

@rwblair
Copy link
Member

rwblair commented Nov 21, 2019

Ok would like to wait until we get an ruling on bids-standard/bids-specification#372 for the changes in this PR made to dataset_description.json of ds248.

@rwblair
Copy link
Member

rwblair commented Dec 3, 2019

No objections so far in bids-standard/bids-specification#372, merging, can revert if for some reason the community rules the other way.

@rwblair rwblair merged commit ac55ad3 into bids-standard:master Dec 3, 2019
@sappelhoff sappelhoff deleted the bump branch December 4, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants