-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples for Microscopy BEP031 #286
Conversation
…02' with sample files.
…N fields in the 'sem002' subject's file sidecar.
…le'. Added it to the 'sem001' dataset and incorporated the session folder structure for 'sem002'.
… fields 'PhysicalSizeX', Y and Z.
…added multiple samples per subject and removed the column 'derived_from' in samples.tsv.
Co-authored-by: mariehbourget <54086142+mariehbourget@users.noreply.github.com>
Co-authored-by: mariehbourget <54086142+mariehbourget@users.noreply.github.com>
Co-authored-by: mariehbourget <54086142+mariehbourget@users.noreply.github.com>
Co-authored-by: mariehbourget <54086142+mariehbourget@users.noreply.github.com>
Co-authored-by: mariehbourget <54086142+mariehbourget@users.noreply.github.com>
…r SPIM dataset, snd session for SEM dataset, etc.).
Co-authored-by: mariehbourget <54086142+mariehbourget@users.noreply.github.com>
Co-authored-by: mariehbourget <54086142+mariehbourget@users.noreply.github.com>
Co-authored-by: mariehbourget <54086142+mariehbourget@users.noreply.github.com>
Co-authored-by: mariehbourget <54086142+mariehbourget@users.noreply.github.com>
Co-authored-by: mariehbourget <54086142+mariehbourget@users.noreply.github.com>
Co-authored-by: mariehbourget <54086142+mariehbourget@users.noreply.github.com>
Co-authored-by: mariehbourget <54086142+mariehbourget@users.noreply.github.com>
…ing' and 'Environment' now 'SampleEnvironment'.
… (in %) have been changed from 2 to 98.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small thing to add when this is ready to merge (not urgent)
a summary table in the README.md of the repo
https://github.com/bids-standard/bids-examples#dataset-index
Co-authored-by: Julia Guiomar Niso Galán <guiomar.niso@ctb.upm.es>
Hi @mariehbourget! I think that it might be convenient that the 4 chunks of the samples A and B of the example |
Hi @guiomar, thank you for this suggestion. I had a similar thought yesterday. My issue is that those examples are "empty" data. So they are just empty 1x1x1 pixel files. I was wondering if adding chunk transformation to empty images would be more confusing. But I agree this could help to have an example so I think we could explain it in the README of the dataset. |
Hi @Remi-Gau, we are updating our examples and have a small question. |
I would say that it should be 1.7.0. One of the long term goal would be to have the validator check that a dataset fits the requirements of the BIDS version mentioned in the description. For you it will be version 1.7. That being said I just realized that this means that some of the BIDS datasets for PET need to have their version number bumped up to 1.6.0. @mariehbourget are you sure you don't want to join us as maintainers: you definitely have a knack for internal consistency. 😍 👍 |
Following the Microscopy BEP community review, we will update the examples in this repo in-parallel with the implementation of the validator.
|
…ChunkTransformationAxis field. 2. Add an explanation in the README of the dataset.
Add json per chunk
2. Change "BIDSVersion" of example datasets to "1.7.0"
Update the data type and BIDSVersion
@guiomar, as you suggested, we added examples of the @Remi-Gau, the examples are completed with the latest changes from the community review. I also included the summary table in the README.md file. |
Just as a follow-up: |
This PR provides 2 example datasets for Microscopy data (BEP031, @mariehbourget, @jcohenadad).
micr_SEM
: 1 sample, multisession, in PNG formatmicr_SPIM
: 2 samples, with multiple chunks, in OME-TIFF formatAs discussed, OME-TIFF files are small 1x1x1 pixel files in order to preserve metadata for validation.
The microscopy validator is not ready yet but should follow in about 2 weeks.
The example datasets may be updated while finalizing the validator and after community review of the BEP031 spec.
Thanks to @etiennebergeron for his help building the datasets!