Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: eeg ds003645s hed demo #442

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

effigies
Copy link
Contributor

This fixes two issues with eeg_ds003645s_hed_demo identified by the schema validator.

  1. electrodes.tsv does not permit a task entity.
  2. sub-004/ses-1 EEG files lacked a sidecar. I just copied what was consistent in sub-002/003 into a top-level sidecar.

Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing.... ds003645 on openNeuro validated and it uses task in the electrodes file names. I looked in the spec and see that task now isn't in the filename spec for electrodes. Is this new?

@effigies
Copy link
Contributor Author

The validator was written more leniently than the spec. I have recently pushed bids-standard/bids-specification#1722, which re-added the run to electrodes to accommodate existing data because it had been mentioned in the spec previously. If it would be useful to re-add task to match existing usage, we could open another PR there as well.

But I would like to go ahead and get this in for the sake of testing anyway. We can re-relax the validator separately, if needed.

@effigies effigies merged commit 8c38429 into bids-standard:master Apr 26, 2024
7 checks passed
@effigies effigies deleted the fix/eeg_ds003645s_hed_demo branch April 26, 2024 13:45
@VisLab
Copy link
Member

VisLab commented Apr 26, 2024

@arnodelorme @dungscout96 This may be an issue for bids-matlab-tools. I have posted sccn/EEG-BIDS#212.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants