-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding micr_XPCTzarr dataset #455
Conversation
...rr/sub-LADAF-2020-31/ses-01/micr/sub-LADAF-2020-31_ses-01_sample-brain_XPCT.ome.zarr/0/0/0/0
Outdated
Show resolved
Hide resolved
micr_XPCTzarr/sub-LADAF-2020-31/ses-01/micr/sub-LADAF-2020-31_ses-01_sample-brain_XPCT.json
Outdated
Show resolved
Hide resolved
micr_XPCTzarr/sub-LADAF-2020-31/sub-LADAF-2020-31_sessions.json
Outdated
Show resolved
Hide resolved
micr_XPCTzarr/sub-LADAF-2020-31/ses-01/micr/sub-LADAF-2020-31_ses-01_sample-brain_XPCT.json
Outdated
Show resolved
Hide resolved
correction: typo on diacritic in name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased to simplify merging. Apologies, I didn't realize this was your main branch.
Two small suggestions you can merge directly through github.
micr_XPCTzarr/sub-01/ses-01/micr/sub-01_ses-01_sample-brain_photo.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
…oto.json Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@bids-standard/maintainers This PR uses a BIDS-URI. These are supported by the schema validator but not the legacy validator. Do we just want to exclude this dataset from legacy validation, or fall back to the subject-relative path? |
+1 to exclude from legacy validation |
Did https://github.com/bids-standard/bids-validator/pull/2069 instead. Running locally, only EMPTY_FILES complains: ❯ bids-validator/bin/bids-validator ../examples/micr_XPCTzarr
bids-validator@1.14.9-dev.0
1: [ERR] Empty files not allowed. (code: 99 - EMPTY_FILE)
./sub-01/ses-01/micr/sub-01_ses-01_sample-brain_XPCT.ome.zarr/0/0/0/0
Please visit https://neurostars.org/search?q=EMPTY_FILE for existing conversations about this issue.
1: [WARN] Tabular file contains custom columns not described in a data dictionary (code: 82 - CUSTOM_COLUMN_WITHOUT_DESCRIPTION)
./samples.tsv
Evidence: Columns: sample_info not defined, please define in: /samples.json
Please visit https://neurostars.org/search?q=CUSTOM_COLUMN_WITHOUT_DESCRIPTION for existing conversations about this issue.
Summary: Available Tasks: Available Modalities:
12 Files, 136.75KB Microscopy
1 - Subject
1 - Session
If you have any questions, please post on https://neurostars.org/tags/bids. |
Addition of an example dataset for the XPCT suffix for microscopy in the OME-Zarr (NGFF) file format.