-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example datasets for bep036 #465
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks! I'm guessing you left it in draft state becausew of pheno001 and pheno002, right?
I think we should remove the age_at_visit
column/field from all phenotype/
measurement tools and instead provide a root-level sessions file with that field. Should we maybe take that a step farther and RECOMMEND or say it's OPTIONAL to add age
to the sessions file?
I like that idea. It's redundant information that can be aggregated to sessions level, and can be a recommendation in the BEP. |
It's in Draft state because I haven't prepared |
"f": "Female" | ||
} | ||
}, | ||
"age_at_visit": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"age_at_visit": { | |
"age": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, age_at_visit
would be the same as age
and that's the reason I changed it to age_at_visit
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,3 @@ | |||
participant_id sex age_at_visit MRI ace demographics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
participant_id sex age_at_visit MRI ace demographics | |
participant_id sex age MRI ace demographics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as previous comment
Co-authored-by: Eric Earl <eric.earl@nih.gov>
Co-authored-by: Eric Earl <eric.earl@nih.gov>
Co-authored-by: Eric Earl <eric.earl@nih.gov>
Co-authored-by: Eric Earl <eric.earl@nih.gov>
Got a question from @dominikwelke -- Could this PR include an example showing how to represent multiple runs from one participant-session? @ericearl mentioned today this is easily done by adding a |
Added
pheno001
andpheno002
example dataset inspired by ds004215 on OpenNeuro but significantly modified to keep it simple and easy to convey the various use cases proposed in BEP036.Use cases covered (and to be added to this PR):
pheno001
- Single session with both phenotype and imaging datapheno002
- Two sessions with one imaging data only sessionpheno003
- Two sessions with one phenotype data only sessionpheno004
- Two sets of sessions. One set of sessions (e.g. screening, baseline, followup, etc) for phenotype data and another set of sessions (e.g. 01, 02, etc) for imaging data.Still in draft state but would appreciate any and all feedback.
Pinging co-contributors: @ericearl @SamGuay @surchs