-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DWI] How to encode ADC/TRACE volumes? #1723
Comments
since those scanner derivatives are exported in some other cases than DWI, it makes sense +1 |
Arguing against the first option, |
For the first option, wouldn't the |
I voted for new suffixes, but I also think BEP016 is relevant and would be happy with mdp and dwimap here |
Slightly off the main topic, but I wonder whether |
@CPernet Thanks for raising that point, Cyril. Do you have an example of such a case? Would it still make sense to put them under @smeisler Re @mattcieslak /@arokem I suppose BEP016 is on-topic and I kind of wish I'd put a "Whatever BEP016 says" option there. With it as tilted as the result already is, I think we cannot legitimately put it in this vote. I would suggest a new topic where we hash out BEP016 interactions and see if it justifies another vote between the winner of this poll and the outcome of that discussion. |
I think we discussed this and should go for |
I see. I misunderstood, I thought you were saying TRACE/ADC were used in non-DWI contexts. Thank you for clarifying. |
I've opened #1725. The text is synthesized from reading https://mriquestions.com/trace-vs-adc-map.html, but I have no practical experience. Expert review would be appreciated. |
Popular option " 🚀 Create TRACE and ADC suffixes" risks an unwanted expansion in suffices once the principle extends beyond this one use case; explanation below the line. I would personally make a proposal further changing the comments mentioning BEP016:
On Siemens MRs, the derivative images that can be auto-generated by the DWI sequences are I believe:
Given any of these can be from the same sequence through a set of checkboxes, I don't think that it would be appropriate to allocate suffices for some but not all. Assuming that one wanted new suffices to cover all of these, the problem then is how to deal with all of the other mechanisms that themselves create all sorts of parametric maps. Some pipelines may fit the tensor model, and yield one or more of these same derivatives, albeit likely with some image pre-processing having happened beforehand; others will fit other models, and will yield different derivatives. I figure there's two options here:
Personally I don't like either of these. I think the fundamental source of the problem is trying to sneak scanner-generated derivatives into "raw". If you accept that scanner-generated derivatives are "derivatives", I believe the landscape becomes much more clear. Edit: As per comment and link therein, separating scanner-generated derivatives from raw data may not be a fan favourite. So now I'll have to add an argument I decided to omit from my original post for simplicity. Scanner-generated derivatives could follow the conventions established (or being created) for derivatives (eg.
If such scanner-generated derivatives can be stored in raw datasets, obeying the same naming conventions as would be used were those derivatives to have been generated using a downstream processing pipeline, then the demands around per-file distinction between raw and derived may need to be thought about more carefully, since a derivative file (being eg. a DWI map file encoding ADC) could now very clearly be "permissible" as a raw data file. Now maybe the issue here is that the quoted sentences are in fact not equivalent, and the latter is the more crucial one, ie. a derivative dataset can't have a file that has exactly the same name as a raw file unless it's an exact duplicate, and I'm unfairly picking on the word "permissible". So if a pipeline were to generate an ADC image based on pre-processed DWI data, but its path were to collide with a (present, not hypothetical) scanner-generated one, disambiguation would need to be performed (and that disambiguation would have to be performed unilaterally on the pipeline derivative). What that disambiguation should be isn't immediately clear to me: " One advantage of scanner-generated derivatives being in their own directory separated from the raw data is that this wouldn't be an issue. |
@Lestropie: What do you think of the other (entity-based) option for change?
What about using an entity for this, and adding the @CPernet : your recent comment suggests that you also favor an entity-based solution (rather than suffices). Does that change your original vote here? |
@arokem: Response in comment update (trying to obey RoE). |
Oops. Sorry for messing up and not following the RoE! |
issue 1: raw vs derivatives - derivatives are objects computed from BIDS raw |
issue 2: |
Your idea
Scanners are increasingly generating ADC/TRACE volumes, and BIDS now considers scanner-generated derivatives to be raw enough to not contort ourselves into moving portions of the output into a
derivatives/
subdirectory.These volumes right now are best considered DWI volumes, with no applicable bval/bvecs, but at least the validator expects DWI to be 4D and have bval/bvec sidecars.
I would like to push the issue and just have a vote. Here are our options (use the emoji responses to indicate your vote):
acq-ADC_dwi.nii[.gz]
andacq-TRACE_dwi.nii[.gz]
as special DWI images that can be 3D and not require bval/bvec. (Vote for this if you would prefer an entity, even if notacq
.)dwi/
datatype directory to refer to single-volume images with no bval/bvec requirements.Rules of engagement
In the interest of keeping this discussion short, I would ask commenters to not address one another, but to limit themselves to a single post that argues for or against one or more of these options. If all you want to do is show support for one option, do it by voting.
References
The text was updated successfully, but these errors were encountered: