-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMA] Tabular metadata rules for both top and second-level tabular files #1006
Conversation
Test failure seems to be some website which isn't available and was not introduced by this PR. Might even be temporary, but apparently I don't have permission to re-run the tests. |
Attn was brought up in bids-standard#1006 (comment) by @TheChymera
linkchecker fail is mitigated/merged. I am really not sure on the motivation behind "Documenting file identifiers such as README and _sessions as suffixes..", in particular for those files like CHANGES. Could you provide more detail here or point to specific discussions which lead to that? |
68c92a6
to
ca69df8
Compare
ca69df8
to
566543b
Compare
I have incorporated the amendments from last week's meeting which reduced the scope of “suffixification”. This seems like a fairly simple self-contained addition of files previously not covered by the YAML which closes #978 . So maybe we could discuss whether this can just be pulled today? One small addition which I'd like to mention is that now we have temporarily given up on homogenizing the naming specification for all files. |
* Representation of second-level files added. * Homogenization of modality and non-modality file representation. * Documenting file identifiers such as README and _sessions as suffixes.. Closes: bids-standard#978 Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
566543b
to
a4b4584
Compare
FWIW I approve of moving participants and samples into this group, but also okay with postponing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1006 +/- ##
=======================================
Coverage 35.13% 35.13%
=======================================
Files 8 8
Lines 834 834
=======================================
Hits 293 293
Misses 541 541 ☔ View full report in Codecov by Sentry. |
suffixes..
Co-authored-by: Taylor Salo tsalo006@fiu.edu
As per #987 (comment)
@tsalo @yarikoptic