Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] Tabular metadata rules for both top and second-level tabular files #1006

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

TheChymera
Copy link
Collaborator

  • Representation of second-level files added.
  • Homogenization of modality and non-modality file representation.
  • Documenting file identifiers such as README and _sessions as
    suffixes..

Co-authored-by: Taylor Salo tsalo006@fiu.edu


As per #987 (comment)

@tsalo @yarikoptic

@TheChymera
Copy link
Collaborator Author

Test failure seems to be some website which isn't available and was not introduced by this PR. Might even be temporary, but apparently I don't have permission to re-run the tests.

yarikoptic added a commit to yarikoptic/bids-specification that referenced this pull request Feb 10, 2022
@yarikoptic
Copy link
Collaborator

linkchecker fail is mitigated/merged. I am really not sure on the motivation behind "Documenting file identifiers such as README and _sessions as suffixes..", in particular for those files like CHANGES. Could you provide more detail here or point to specific discussions which lead to that?

@TheChymera
Copy link
Collaborator Author

@tsalo @yarikoptic

I have incorporated the amendments from last week's meeting which reduced the scope of “suffixification”. This seems like a fairly simple self-contained addition of files previously not covered by the YAML which closes #978 .

So maybe we could discuss whether this can just be pulled today?

One small addition which I'd like to mention is that now we have temporarily given up on homogenizing the naming specification for all files.
Thus we have just created a representation for 2 new files which behave analogously to rules/datatypes/*.yaml without changing the representations of other non-modality files.
Perhaps it would be better, after all, to put the new tabular_metadata.yaml file in rules/datatypes/tabular_metadata.yaml, as previously suggested?
This would also make parsing of the schema into regex or placeholder example paths easier and compatible with current functions.

* Representation of second-level files added.
* Homogenization of modality and non-modality file representation.
* Documenting file identifiers such as README and _sessions as
  suffixes..

Closes: bids-standard#978
Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
@effigies
Copy link
Collaborator

FWIW I approve of moving participants and samples into this group, but also okay with postponing it.

@effigies effigies changed the title [ENH] Tabular metadata rules for both top and second-level tabular files [SCHEMA] Tabular metadata rules for both top and second-level tabular files Feb 17, 2022
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tsalo tsalo added the schema Issues related to the YAML schema representation of the specification. Patch version release. label Feb 17, 2022
@effigies effigies merged commit 6c9d9ec into bids-standard:master Feb 18, 2022
@TheChymera TheChymera deleted the tabular_metadata branch February 18, 2022 16:39
@sappelhoff sappelhoff added the exclude-from-changelog This item will not feature in the automatically generated changelog label Aug 7, 2022
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.13%. Comparing base (a4b4584) to head (a4b4584).
Report is 1473 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1006   +/-   ##
=======================================
  Coverage   35.13%   35.13%           
=======================================
  Files           8        8           
  Lines         834      834           
=======================================
  Hits          293      293           
  Misses        541      541           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants