Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] Add datatypes field to datatype rule files #1012

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 17, 2022

Closes None.

Changes proposed:

  • Add a datatypes field to the datatype rule files, so that the folder structure in the rules folder can be for readability, rather than something that implies the schema's structure.

What we won't tackle in this PR, but which is important, is that the schema code needs to be updated to use the new datatypes field instead of the directory/filename structure that is currently used to organize the schema.

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.50%. Comparing base (ee9e8b5) to head (e2bafcc).

Additional details and impacted files
@@                Coverage Diff                @@
##           schema-sprint    #1012      +/-   ##
=================================================
+ Coverage          70.53%   71.50%   +0.96%     
=================================================
  Files                  9        9              
  Lines                930      930              
=================================================
+ Hits                 656      665       +9     
+ Misses               274      265       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo added the schema Issues related to the YAML schema representation of the specification. Patch version release. label Feb 17, 2022
@effigies
Copy link
Collaborator

Plan on merging this with or without schemacode changes to make the field available to tooling. Note that merging as is will mean that we can't take advantage of the reorganization potential until there are schemacode changes.

@tsalo tsalo added the schema-structure Changes to the fundamental organization/structure of the YAML schema. Minor version release. label Apr 11, 2022
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@effigies effigies changed the base branch from master to schema-sprint April 14, 2022 18:20
@effigies effigies marked this pull request as ready for review April 14, 2022 18:21
@effigies effigies merged commit b3dbb44 into bids-standard:schema-sprint Apr 14, 2022
@tsalo tsalo deleted the datatype-datatypes branch April 14, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema Issues related to the YAML schema representation of the specification. Patch version release. schema-structure Changes to the fundamental organization/structure of the YAML schema. Minor version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants