Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] Add extensions to schema #1036

Merged
merged 16 commits into from
Mar 30, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Mar 22, 2022

Closes #1035.

Changes proposed:

  • Add a YAML file to schema/objects/ with definitions of file extensions.
  • Add valid extensions that were missing for meg and headshape files.

No meaningful names or definitions yet.
@tsalo tsalo added the schema Issues related to the YAML schema representation of the specification. Patch version release. label Mar 22, 2022
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.50%. Comparing base (4a6c49a) to head (7e94f22).
Report is 1460 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1036       +/-   ##
===========================================
+ Coverage   34.05%   71.50%   +37.45%     
===========================================
  Files           8        9        +1     
  Lines         834      930       +96     
===========================================
+ Hits          284      665      +381     
+ Misses        550      265      -285     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo marked this pull request as ready for review March 22, 2022 17:47
@tsalo tsalo marked this pull request as draft March 22, 2022 17:49
@tsalo
Copy link
Member Author

tsalo commented Mar 22, 2022

The following suffixes are actually missing from the schema:

  • .trg
  • .md
  • .pos
  • .rst
  • .chn
  • .txt

I think txt, rst, and md are all added for the first time in #1033, but that means trg, pos, and chn are missing.
EDIT: Added in 0acbfbe

@tsalo tsalo marked this pull request as ready for review March 24, 2022 18:02
src/schema/objects/extensions.yaml Outdated Show resolved Hide resolved
tsalo and others added 2 commits March 29, 2022 17:30
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from my one comment, this lgtm

src/schema/objects/extensions.yaml Outdated Show resolved Hide resolved
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
@tsalo tsalo merged commit edd6b0e into bids-standard:master Mar 30, 2022
@tsalo tsalo deleted the extensions-in-schema branch March 30, 2022 16:41
@sappelhoff sappelhoff added the exclude-from-changelog This item will not feature in the automatically generated changelog label Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Define extensions in the schema
4 participants