[FIX] Rename channels.tsv column: orientation_component to component

[sjeung]

Following the discussion on issue:

• "orientation_component" in BIDS-NIRS conflicts with "component" in motion BEP #1393

(closes #1393)

• update orientation_component column in *_channels.tsv to component to cover non-orientation spatial channels and
• wording change in motion channel description in NIRS spec.

accompanying validator PR:

• https://github.com/bids-standard/bids-validator/pull/1629

[sjeung]

Tagging @sappelhoff, I think reviewers were autoassigned

[codecov]

Codecov Report

Base: 88.65% // Head: 88.65% // No change to project coverage 👍

Coverage data is based on head (b0f6058) compared to base (134f532).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1417   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files          11       11           
  Lines        1084     1084           
=======================================
  Hits          961      961           
  Misses        123      123           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[sappelhoff]

Thanks @sjeung!

I'll check if we would also need to adjust the BIDS validator if these changes were to be merged.

---

I think you also need to edit src/schema/rules/checks/nirs.yaml --> there is an OrientationComponent in there as well.

A good trick to catch every specific word you want to edit is to use an editor like VSCode that allows you to open a full directory and then search all files in that directory. for example in VSCode that can be done with Ctrl+Shift+F.

If you don't have VSCode but want to search a GitHub repo, you can also navigate to the repo in your browser and then press dot (.) to open up a VSCode instance in your browser, and from there you can do the search trick.

See screenshot:

tagging @JuliusWelzel as this trick might be handy to know for you as well.

[sappelhoff]

Thanks @sjeung and all involved reviewers.

@sjeung and @JuliusWelzel I hope you can now proceed with taking these adjustments to the spec, validator, and examples so that we'll soon be ready for the BEP029 MOTION community review 🙂