[ENH] Permit CITATION.cff as structured alternative to some dataset_description fields #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
effigies
force-pushed
the
enh/citation_cff
branch
from
61186d4
to
1dd848a
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1525 +/- ##
==========================================
- Coverage 87.83% 87.68% -0.15%
==========================================
Files 16 14 -2
Lines 1356 1291 -65
==========================================
- Hits 1191 1132 -59
+ Misses 165 159 -6 ☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
enh/citation_cff
branch
from
1dd848a
to
186c859
Compare
effigies
changed the title
effigies
force-pushed
the
enh/citation_cff
branch
from
186c859
to
598a6c0
Compare
|
LGTM so far |
|
This looks good so far. |
Remi-Gau
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #901.
Legacy validator PR: https://github.com/bids-standard/bids-validator/pull/1737
The short-term fix for the legacy validator would be addingCITATION.cffto the file regexes, but I do not currently plan to write code to enforce the mutual exclusion. Unless there's strong feeling that all aspects must be implemented by the legacy validator until we're ready to flip the switch?