-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Clarify that electrodes.tsv is optional for MEG, for use with simultaneous (i)EEG #1555
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d04ffe0
[FIX] Clarify that electrodes.tsv is permissible for simultaneous MEG…
effigies b5a222a
[SCHEMA] Permit electrodes.tsv for MEG
effigies befd54c
[SCHEMA] electrodes.tsv is RECOMMENDED if EEGChannelCount > 0
effigies 3772352
Address review
effigies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Rules for MEG data that cannot be defined in tables | ||
--- | ||
MEGElectrodesRecommended: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as outlined in #1550 (comment), I think this should be optional --> this electrode information can also be stored in |
||
issue: | ||
code: MEG_EEG_ELECTRODES_RECOMMENDED | ||
message: | | ||
A nonzero EEGChannelCount for MEG datasets indicates the presence of EEG | ||
channels. A corresponding `electrodes.tsv` file should be be added. | ||
level: warning | ||
selectors: | ||
- suffix == "meg" | ||
- sidecar.EEGChannelCount > 0 | ||
checks: | ||
- type(associations.electrodes) != 'null' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO the SHOULD should become a MAY.
So far, the spec allowed for recording electrode positions in the
_headshape
: https://bids-specification.readthedocs.io/en/stable/glossary.html#headshape-suffixes