-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add support for HiP-CT #1686
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1686 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 16 16
Lines 1351 1351
=======================================
Hits 1188 1188
Misses 163 163 ☔ View full report in Codecov by Sentry. |
This seems fine to me, and there were no objections on the discussion #1646. @jcohenadad Do you see any problems with this? |
on the contrary, this is a great addition! |
Thanks! I removed the draft mode |
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Note that by the rules we do need a second approving review by a community member. (It does not need to be a maintainer.) |
Resolves: #1646
This PR introduces a new
hipCT
microscopy suffix.It does not make any changes to the required or optional metadata.
To me, HiP-CT is not a quantitative modality, so I do not see any parameters that would be required for downstream analysis.
Please give feedback if you feel that this is not correct and that hip-ct-specific metadata should be added.
I am leaving it as a draft PR for now.
cc @satra @ucbpclw