Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add support for HiP-CT #1686

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Conversation

balbasty
Copy link
Contributor

Resolves: #1646

This PR introduces a new hipCT microscopy suffix.

It does not make any changes to the required or optional metadata.
To me, HiP-CT is not a quantitative modality, so I do not see any parameters that would be required for downstream analysis.
Please give feedback if you feel that this is not correct and that hip-ct-specific metadata should be added.

I am leaving it as a draft PR for now.

cc @satra @ucbpclw

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (327bece) to head (cfe7ac1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1686   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files          16       16           
  Lines        1351     1351           
=======================================
  Hits         1188     1188           
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator

This seems fine to me, and there were no objections on the discussion #1646.

@jcohenadad Do you see any problems with this?

@jcohenadad
Copy link
Contributor

@jcohenadad Do you see any problems with this?

on the contrary, this is a great addition!

@balbasty balbasty marked this pull request as ready for review February 16, 2024 18:37
@balbasty
Copy link
Contributor Author

Thanks! I removed the draft mode

@effigies
Copy link
Collaborator

effigies commented Mar 8, 2024

Note that by the rules we do need a second approving review by a community member. (It does not need to be a maintainer.)

@effigies effigies merged commit 19f8078 into bids-standard:master Mar 11, 2024
26 checks passed
@balbasty balbasty mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for HiP-CT
5 participants