Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add TablePosition tag to MRI #1690

Merged
merged 24 commits into from
Aug 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
519bd7f
Add TablePosition tag to the MRI Hardware section and to the glossary
po09i Jan 29, 2024
0f3d4bc
Added Alexandre D'Astous to the list of contributors
po09i Jan 29, 2024
3d71f59
Add TablePosition tag to the MRI Hardware section and to the glossary
po09i Jan 29, 2024
ef8a798
Added Alexandre D'Astous to the list of contributors
po09i Jan 29, 2024
3320e94
Merge branch 'master' into ad/table-position
po09i Feb 13, 2024
903b5ac
Merge branch 'master' into ad/table-position
po09i Feb 27, 2024
53212ee
Merge branch 'master' into ad/table-position
po09i Mar 14, 2024
4936eaf
Merge master
po09i Mar 14, 2024
3bb11d1
Update TablePosition metadata according to code review.
po09i Mar 14, 2024
bb55a38
Minor rewording of the origin of the table position
po09i Mar 22, 2024
55b9ac6
Merge branch 'master' into ad/table-position
po09i Mar 29, 2024
4a171a0
Change from patient coordinate system to device
po09i Apr 16, 2024
1d4f0ca
Merge branch 'master' into ad/table-position
po09i Apr 16, 2024
054d877
Apply suggestions from code review
po09i Apr 16, 2024
2142da3
Apply suggestions from code review
po09i Apr 16, 2024
bc70fc1
Remove regardless
po09i Apr 16, 2024
b2529a0
Change e.g.
po09i Apr 16, 2024
383fbe6
Remove latin abbreviations
po09i Apr 16, 2024
1d4ffe0
Update the definition
po09i Jun 5, 2024
32cabe2
Merge branch 'master' into ad/table-position
po09i Jun 20, 2024
b76962d
Merge branch 'master' into ad/table-position
po09i Jul 5, 2024
643b369
Merge branch 'master' into ad/table-position
po09i Jul 24, 2024
2eb7a8d
Merge branch 'master' into ad/table-position
po09i Aug 13, 2024
0f4a010
Update src/schema/rules/sidecars/mri.yaml
po09i Aug 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/appendices/contributors.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ If you contributed to the BIDS ecosystem and your name is not listed, please add
| Alexander Jones | 💻🐛 |
| Alexander L. Cohen | 🐛💻📖💬 |
| Alexander von Lautz | 📖 |
| Alexandre D'Astous | 📖 |
| Alexandre Gramfort | 📖💡 |
| Alexandre Hutton | 📖 |
| Alexandre Routier | 📖 |
Expand Down
17 changes: 17 additions & 0 deletions src/schema/objects/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3392,6 +3392,23 @@ SubjectArtefactDescription:
If this field is set to `"n/a"`, it will be interpreted as absence of major
source of artifacts except cardiac and blinks.
type: string
TablePosition:
name: TablePosition
display_name: Table Position
description: |
The table position, relative to an implementation-specific reference point,
often the isocenter. Values must be an array (1x3) of three distances in
millimeters in absolute coordinates (world coordinates). If an observer
stands in front of the scanner looking at it, a table moving to the left,
up or into the scanner (from the observer's point of view) will increase
the 1st, 2nd and 3rd value in the array respectively. The origin is defined
by the image affine.
type: array
minItems: 3
maxItems: 3
items:
type: number
unit: mm
TaskDescription:
name: TaskDescription
display_name: Task Description
Expand Down
16 changes: 16 additions & 0 deletions src/schema/rules/sidecars/mri.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,22 @@ MRIHardware:
MatrixCoilMode: recommended
CoilCombinationMethod: recommended
NumberTransmitCoilActiveElements: optional
TablePosition:
level: optional
level_addendum: recommended if `chunk` entity is present

MRIChunkPosition:
selectors:
- modality == "mri"
- entities.chunk
- match(extension, '\.nii(\.gz)?$')
fields:
TablePosition:
level: recommended
issue:
code: TABLE_POSITION_RECOMMENDED
message: |
TablePosition is RECOMMENDED if the chunk entity is present.

MRISample:
selectors:
Expand Down