Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): Minor issues #1893

Merged
merged 7 commits into from
Aug 20, 2024
Merged

Conversation

effigies
Copy link
Collaborator

This removes a mistargeted issue that was inappropriately warning about EchoTime above and beyond the normal recommendation.

I also remove some required fields from the schema context to recognize that some fields may be absent without meaning the whole file is ill-formed.

Finally, I increase the specificity of some selectors for sidecar metadata to decrease the chance a validator will complain about missing metadata on a file that does not need it.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (b91d0e3) to head (c6bed8c).
Report is 145 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1893   +/-   ##
=======================================
  Coverage   88.10%   88.10%           
=======================================
  Files          16       16           
  Lines        1396     1396           
=======================================
  Hits         1230     1230           
  Misses        166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 9377b20 into bids-standard:master Aug 20, 2024
27 checks passed
@effigies effigies deleted the fix/schema-types branch August 20, 2024 16:49
@effigies effigies added exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release. labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants